-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: refactor and add native addon for complex/float64/conj
#7301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
8965325
9c9007e
f604fa5
bd77ec2
19d177e
74ecbc8
71349bc
dd0c8d2
dbc89d3
eb0d1ae
b83b1aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2025 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var resolve = require( 'path' ).resolve; | ||
var bench = require( '@stdlib/bench' ); | ||
var uniform = require( '@stdlib/random/base/uniform' ); | ||
var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
var Complex128 = require( '@stdlib/complex/float64/ctor' ); | ||
var real = require( '@stdlib/complex/float64/real' ); | ||
var imag = require( '@stdlib/complex/float64/imag' ); | ||
var tryRequire = require( '@stdlib/utils/try-require' ); | ||
var pkg = require( './../package.json' ).name; | ||
|
||
|
||
// VARIABLES // | ||
|
||
var conj = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||
var opts = { | ||
'skip': ( conj instanceof Error ) | ||
}; | ||
|
||
|
||
// MAIN // | ||
|
||
bench( pkg+'::native', opts, function benchmark( b ) { | ||
var values; | ||
var out; | ||
var z; | ||
var i; | ||
|
||
values = [ | ||
new Complex128( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ), | ||
new Complex128( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ) | ||
]; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
z = values[ i%values.length ]; | ||
out = conj( z ); | ||
if ( typeof out !== 'object' ) { | ||
b.fail( 'should return an object' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( isnan( real( out ) ) || isnan( imag( out ) ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,12 @@ | |
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var real = require( '@stdlib/complex/float64/real' ); | ||
var imag = require( '@stdlib/complex/float64/imag' ); | ||
var Complex128 = require( '@stdlib/complex/float64/ctor' ); | ||
|
||
/** | ||
* Returns the complex conjugate of a double-precision complex floating-point number. | ||
* | ||
|
@@ -33,7 +39,7 @@ | |
* // returns <Complex128>[ 5.0, -3.0 ] | ||
*/ | ||
function conj( z ) { | ||
return new z.constructor( z.re, -z.im ); | ||
return new Complex128( real( z ), -imag( z ) ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I think this makes sense now. There is some history here in why |
||
} | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2025 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var Complex128 = require( '@stdlib/complex/float64/ctor' ); | ||
var addon = require( './../src/addon.node' ); | ||
|
||
|
||
// MAIN // | ||
|
||
/** | ||
* Returns the complex conjugate of a double-precision complex floating-point number. | ||
* | ||
* @private | ||
* @param {Complex128} z - complex number | ||
* @returns {Complex128} complex conjugate | ||
* | ||
* @example | ||
* var Complex128 = require( '@stdlib/complex/float64/ctor' ); | ||
* var real = require( '@stdlib/complex/float64/real' ); | ||
* var imag = require( '@stdlib/complex/float64/imag' ); | ||
* | ||
* var z = new Complex128( 5.0, 3.0 ); | ||
* | ||
* var v = conj( z ); | ||
* // returns <Complex128> | ||
* | ||
* var re = real( v ); | ||
* // returns 5.0 | ||
* | ||
* var im = imag( v ); | ||
* // returns -3.0 | ||
kgryte marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
*/ | ||
function conj( z ) { | ||
var v = addon( z ); | ||
return new Complex128( v.re, v.im ); | ||
} | ||
|
||
|
||
// EXPORTS // | ||
|
||
module.exports = conj; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
#/ | ||
# @license Apache-2.0 | ||
# | ||
# Copyright (c) 2025 The Stdlib Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
#/ | ||
|
||
# VARIABLES # | ||
|
||
ifndef VERBOSE | ||
QUIET := @ | ||
else | ||
QUIET := | ||
endif | ||
|
||
# Determine the OS ([1][1], [2][2]). | ||
# | ||
# [1]: https://en.wikipedia.org/wiki/Uname#Examples | ||
# [2]: http://stackoverflow.com/a/27776822/2225624 | ||
OS ?= $(shell uname) | ||
ifneq (, $(findstring MINGW,$(OS))) | ||
OS := WINNT | ||
else | ||
ifneq (, $(findstring MSYS,$(OS))) | ||
OS := WINNT | ||
else | ||
ifneq (, $(findstring CYGWIN,$(OS))) | ||
OS := WINNT | ||
else | ||
ifneq (, $(findstring Windows_NT,$(OS))) | ||
OS := WINNT | ||
endif | ||
endif | ||
endif | ||
endif | ||
|
||
|
||
# RULES # | ||
|
||
#/ | ||
# Removes generated files for building an add-on. | ||
# | ||
# @example | ||
# make clean-addon | ||
#/ | ||
clean-addon: | ||
$(QUIET) -rm -f *.o *.node | ||
|
||
.PHONY: clean-addon | ||
|
||
#/ | ||
# Removes generated files. | ||
# | ||
# @example | ||
# make clean | ||
#/ | ||
clean: clean-addon | ||
|
||
.PHONY: clean |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2025 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#include "stdlib/complex/float64/conj.h" | ||
#include "stdlib/math/base/napi/unary.h" | ||
|
||
STDLIB_MATH_BASE_NAPI_MODULE_Z_Z( stdlib_complex128_neg ) | ||
kgryte marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.