Skip to content

chore: fix JavaScript lint errors (issue #7440) #7443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2025

Conversation

dhernandeez13
Copy link
Contributor

@dhernandeez13 dhernandeez13 commented Jun 22, 2025

This PR fixes the JavaScript linting error related to the redeclaration of TransformStream in lib/node_modules/@stdlib/bench/harness/lib/main.js.

The local variable TransformStream was renamed to StdlibTransformStream to avoid redeclaration lint failures due to name conflicts with the global TransformStream object.

JSDoc comments were intentionally left unchanged to preserve accurate type information.

Description

This pull request:

  • Fixes a variable naming conflict with TransformStream that triggered a linting error.
  • Renames the local TransformStream import to StdlibTransformStream.
  • Ensures that the benchmark module complies with the project's ESLint rules.

Related Issues

Questions

No.

Other

No additional notes.

Checklist


@stdlib-js/reviewers

This PR fixes the JavaScript linting error related to redeclaration of `TransformStream` in `lib/node_modules/@stdlib/bench/harness/lib/main.js`.

The local variable `TransformStream` was renamed to `StdlibTransformStream` to avoid redeclaration lint failures.

JSDoc comments were left unchanged to keep accurate type information.

Related Issues:
resolves stdlib-js#7440
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jun 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 22, 2025

Coverage Report

Package Statements Branches Functions Lines
bench/harness $\color{green}513/513$
$\color{green}+100.00\%$
$\color{green}60/60$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}513/513$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the relevant lint rule should just be disabled. No need to rename the variable.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 22, 2025
@kgryte kgryte merged commit 875aa06 into stdlib-js:develop Jun 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants