Skip to content

chore: address commit comments for commit 18e1770 (issue #7614) #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

anmolsah
Copy link
Contributor

Resolves #7614.

Description

What is the purpose of this pull request?

This pull request addresses two comments from core contributors related to commit 18e1770:

  • Corrected a grammar issue in the introductory sentence of the README.md (with shape parameter. cwith shape parameter c).
  • Removed a redundant sentence in the usage section to avoid repetition.

These small but meaningful improvements help maintain clarity and consistency across the documentation.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No questions at the moment. Happy to make further changes if needed.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

None.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. and removed Good First PR A pull request resolving a Good First Issue. labels Jul 11, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Jul 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 11, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bradford/skewness $\color{green}185/185$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}185/185$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Athan <[email protected]>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jul 11, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 11, 2025
@kgryte kgryte merged commit f9059f4 into stdlib-js:develop Jul 11, 2025
27 checks passed
@anmolsah anmolsah deleted the fix-doc-18e1770 branch July 11, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 18e1770)
3 participants