Skip to content

chore: fix JavaScript lint errors (issue #7744) #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
Merged

chore: fix JavaScript lint errors (issue #7744) #7747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efb57bb
Update get.js
Pradyumn-cloud Jul 26, 2025
cbe5260
docs: revert comment removal
kgryte Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/plot/ctor/lib/props/x-max/get.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var isNull = require( '@stdlib/assert/is-null' );
var max = require( './../../utils/max.js' ); // TODO: replace with mod when written
var max = require( './../../utils/max.js' ); // TODO: replace with stdlib package import when added

Check warning on line 24 in lib/node_modules/@stdlib/plot/ctor/lib/props/x-max/get.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: replace with stdlib package import...'


// FUNCTIONS //
Expand All @@ -39,9 +39,9 @@
if ( arr.length === 0 ) {
return null;
}
tmp = new Array( arr.length );
tmp = [];
for ( i = 0; i < arr.length; i++ ) {
tmp[ i ] = max( arr[ i ] );
tmp.push( max( arr[ i ] ) );
}
return max( tmp );
}
Expand Down