Skip to content

Conversation

NEEKUorAAYUSH
Copy link
Contributor

@NEEKUorAAYUSH NEEKUorAAYUSH commented Aug 13, 2025

Description

This pull request addresses the 4 comments left on commit d269f48:

  1. Move lines 142-145 down to line 234 in README.md.
  2. Remove unused headers in README.md and example.c.
  3. Add missing closing </section> and trailing comment in README.md.

Related Issues

This pull request:

Questions

No questions for reviewers.

Other

No additional information.

Checklist

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Aug 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Aug 13, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/geometric/logcdf $\color{green}295/295$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}295/295$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@NEEKUorAAYUSH NEEKUorAAYUSH changed the title Fix commit comments d269f48 fix(stats/geometric/logcdf): address comments from commit d269f48 Aug 13, 2025
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 13, 2025
@kgryte kgryte changed the title fix(stats/geometric/logcdf): address comments from commit d269f48 chore: address comments from commit d269f48 Aug 13, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 13, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte merged commit 59bb1b1 into stdlib-js:develop Aug 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit d269f48)
3 participants