Skip to content

refactor: use explicit float32 casting in math/base/special/fast/absf #8074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2025
Merged

refactor: use explicit float32 casting in math/base/special/fast/absf #8074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc23445
refactor: added proper `Float32` casting in `math/base/special/fast/a…
nakul-krishnakumar Sep 14, 2025
33c57b3
chore: removed extra casting
nakul-krishnakumar Sep 14, 2025
493a9ca
chore: clean-up
kgryte Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/node_modules/@stdlib/math/base/special/fast/absf/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@

'use strict';

// MODULES //

var f32 = require( '@stdlib/number/float64/base/to-float32' );


// VARIABLES //

var ZERO = f32( 0.0 );


// MAIN //

/**
Expand Down Expand Up @@ -47,8 +57,9 @@
* // returns NaN
*/
function absf( x ) {
if ( x < 0.0 ) {
return -x;
x = f32( x );
if ( x < ZERO ) {
return f32( -x );
}
return x;
}
Expand Down
9 changes: 5 additions & 4 deletions lib/node_modules/@stdlib/math/base/special/fast/absf/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
// MODULES //

var tape = require( 'tape' );
var f32 = require( '@stdlib/number/float64/base/to-float32' );
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var PINF = require( '@stdlib/constants/float32/pinf' );
Expand All @@ -37,14 +38,14 @@ tape( 'main export is a function', function test( t ) {
});

tape( 'the function computes the absolute value of a number', function test( t ) {
t.strictEqual( absf( -2.0 ), 2.0, 'returns expected value' );
t.strictEqual( absf( 3.0 ), 3.0, 'returns expected value' );
t.strictEqual( absf( 0.0 ), 0.0, 'returns expected value' );
t.strictEqual( absf( f32( -2.0 ) ), f32( 2.0 ), 'returns expected value' );
t.strictEqual( absf( f32( 3.0 ) ), f32( 3.0 ), 'returns expected value' );
t.strictEqual( absf( f32( 0.0 ) ), f32( 0.0 ), 'returns expected value' );
t.end();
});

tape( 'the function returns `-0` if provided `-0` (not IEEE 754 compliant)', function test( t ) {
t.strictEqual( isNegativeZerof( absf( -0.0 ) ), true, 'returns expected value' );
t.strictEqual( isNegativeZerof( absf( f32( -0.0 ) ) ), true, 'returns expected value' );
t.end();
});

Expand Down
9 changes: 5 additions & 4 deletions lib/node_modules/@stdlib/math/base/special/fast/absf/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var f32 = require( '@stdlib/number/float64/base/to-float32' );
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var PINF = require( '@stdlib/constants/float32/pinf' );
Expand All @@ -46,14 +47,14 @@ tape( 'main export is a function', opts, function test( t ) {
});

tape( 'the function computes the absolute value of a number', opts, function test( t ) {
t.strictEqual( absf( -2.0 ), 2.0, 'returns expected value' );
t.strictEqual( absf( 3.0 ), 3.0, 'returns expected value' );
t.strictEqual( absf( 0.0 ), 0.0, 'returns expected value' );
t.strictEqual( absf( f32( -2.0 ) ), f32( 2.0 ), 'returns expected value' );
t.strictEqual( absf( f32( 3.0 ) ), f32( 3.0 ), 'returns expected value' );
t.strictEqual( absf( f32( 0.0 ) ), f32( 0.0 ), 'returns expected value' );
t.end();
});

tape( 'the function returns `-0` if provided `-0` (not IEEE 754 compliant)', opts, function test( t ) {
t.strictEqual( isNegativeZerof( absf( -0.0 ) ), true, 'returns expected value' );
t.strictEqual( isNegativeZerof( absf( f32( -0.0 ) ) ), true, 'returns expected value' );
t.end();
});

Expand Down