Skip to content

Conversation

Payal-Goswami
Copy link
Contributor

Resolves #8082.

Description

This pull request:

  • Fixes ESLint/style errors in benchmark.js for Issue Fix JavaScript lint errors #8082.
  • Replaced explicit undefined with void 0.
  • Moved all var declarations to the top of functions.
  • Added comments inside empty functions where needed.
  • Fixed max-statements-per-line issues.
  • File now passes npx eslint --fix without errors.

Note: This PR only fixes ESLint/style issues in benchmark.js. No functional changes were made, so the behavior of the code remains unchanged. Existing tests were not run locally due to Windows Make limitations, but these changes do not affect test outcomes.

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Sep 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 16, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/is-odd $\color{green}262/262$
$\color{green}+100.00\%$
$\color{green}18/18$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}262/262$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 17, 2025
@kgryte kgryte merged commit 510bbde into stdlib-js:develop Sep 17, 2025
13 checks passed
@Payal-Goswami
Copy link
Contributor Author

@kgryte Thanks for reviewing and merging! 🙏✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants