Skip to content

test: add tests to ndarray/some-by for complete test coverage #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2025
Merged

test: add tests to ndarray/some-by for complete test coverage #8125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6826ae9
test: add tests to ndarray/some-by for complete test coverage
headlessNode Sep 22, 2025
b0b9cb6
Merge branch 'stdlib-js:develop' into tests-some-by
headlessNode Sep 23, 2025
d059154
docs: apply suggestions from code review
headlessNode Sep 23, 2025
5c98854
refactor: apply suggestions from code review
headlessNode Sep 23, 2025
4bd3f8c
refactor: apply suggestions from code review
headlessNode Sep 23, 2025
42af74f
test: add tests and clean-up
kgryte Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/node_modules/@stdlib/ndarray/some-by/lib/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ function validate( opts, ndims, options ) {
if ( tmp.length !== opts.dims.length ) {
return new Error( format( 'invalid option. `%s` option contains duplicate indices. Option: [%s].', 'dims', join( opts.dims, ',' ) ) );
}
if ( tmp.length > ndims ) {
return new RangeError( format( 'invalid option. `%s` option specifies more dimensions than exists in the input array. Number of dimensions: %d. Option: [%s].', 'dims', ndims, join( opts.dims, ',' ) ) );
}
opts.dims = tmp;
}
return null;
Expand Down
Loading