Skip to content

Conversation

Payal-Goswami
Copy link
Contributor

@Payal-Goswami Payal-Goswami commented Oct 16, 2025

Progresses #8244

Description

This pull request:

removes unused ESLint disable directives (/* eslint-disable no-new-wrappers */) from several example files within the @stdlib/assert module.

These directives are unnecessary because the affected files:

  • Do not use global wrapper constructors like new Number(), new String(), or new Boolean().
  • Or, when such constructors appear, they are locally shadowed (e.g., var Number = require('@stdlib/number/ctor');).

Removing these unused disables prevents random CI failures caused by the --report-unused-disable-directives ESLint flag.

Files Updated (5)

lib/node_modules/@stdlib/assert/is-number/examples/index.js
lib/node_modules/@stdlib/assert/is-boolean-array/examples/index.js
lib/node_modules/@stdlib/assert/is-boolean/examples/index.js
lib/node_modules/@stdlib/assert/is-composite/examples/index.js
lib/node_modules/@stdlib/assert/is-cube-number/examples/index.js

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 16, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/is-boolean-array $\color{green}78/78$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}78/78$
$\color{green}+100.00\%$
assert/is-boolean $\color{green}325/325$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}325/325$
$\color{green}+100.00\%$
assert/is-composite $\color{green}247/247$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}247/247$
$\color{green}+100.00\%$
assert/is-cube-number $\color{green}255/255$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}255/255$
$\color{green}+100.00\%$
assert/is-number $\color{green}330/330$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}330/330$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title chore: remove unused eslint-disable no-new-wrappers directives chore: remove unused ESLint directives Oct 16, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Oct 16, 2025
@kgryte
Copy link
Member

kgryte commented Oct 16, 2025

Note that this PR does not actually fully resolve #8244. It only addresses a few of the files which were mentioned.

@kgryte
Copy link
Member

kgryte commented Oct 16, 2025

As the CI failure does not stem from changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit 82439fb into stdlib-js:develop Oct 16, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants