Skip to content

feat: add symbol/search #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: add symbol/search #8523

wants to merge 5 commits into from

Conversation

@sagar7162
Copy link
Contributor

@sagar7162 sagar7162 commented Nov 13, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves #8480

Description

What is the purpose of this pull request?

This pull request:

  • Adds symbol/search

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@sagar7162
feat: add symbol/search
b23fcce 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 13, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
symbol/search $\color{green}110/110$
$color{green}+100.00%$ 		$\color{red}2/3$
$color{green}+66.67%$ 		$\color{green}0/0$
$color{green}+100.00%$ 		$\color{green}110/110$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Nov 18, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Nov 18, 2025
kgryte
kgryte reviewed Nov 18, 2025
View reviewed changes
kgryte
kgryte reviewed Nov 18, 2025
View reviewed changes
lib/node_modules/@stdlib/symbol/search/docs/repl.txt Outdated
@@ -0,0 +1,18 @@

{{alias}}
Has instance symbol.
Copy link
Member

@kgryte kgryte Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy paste mistakes.

kgryte
kgryte reviewed Nov 18, 2025
View reviewed changes
lib/node_modules/@stdlib/symbol/search/package.json Outdated
{
"name": "@stdlib/symbol/search",
"version": "0.0.0",
"description": "Has instance symbol.",
Copy link
Member

@kgryte kgryte Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description needs updating.

kgryte
kgryte reviewed Nov 18, 2025
View reviewed changes
lib/node_modules/@stdlib/symbol/search/package.json Outdated
"stdlib",
"symbol",
"sym",
"instance",
Copy link
Member

@kgryte kgryte Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keywords need updating.

kgryte
kgryte requested changes Nov 18, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 18, 2025
sagar7162 and others added 4 commits November 18, 2025 14:27
@sagar7162
Merge branch 'stdlib-js:develop' into symbolsearch
d5092a3
@sagar7162 @kgryte
Apply suggestion from @kgryte
95d2c5f 
Co-authored-by: Athan <[email protected]>
Signed-off-by: Sagar Ratna Chaudhary <[email protected]>
@sagar7162
Revise repl.txt to update instance symbol description
9b8d4cf 
Updated documentation for the instance symbol to clarify its purpose and usage.

Signed-off-by: Sagar Ratna Chaudhary <[email protected]>
@sagar7162
Update package description and keywords
d64e753 
Signed-off-by: Sagar Ratna Chaudhary <[email protected]>
@sagar7162 sagar7162 requested a review from kgryte November 18, 2025 09:20
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add symbol/search

3 participants

@sagar7162 @stdlib-bot @kgryte