bench: refactor random number generation in stats/base/dists/signrank #9594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bench:refactor random number generation in stats/base/dists/signrank issue: #4986
Resolves #4986 .
Description
This pull request:
This pull request improves random number generation in JS benchmarks for stats/base/dists/signrank. Specifically:
Moves random number generation out of benchmarking loops to prevent interference with benchmark results.
Uses @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.
Ensures generated random values maintain the same range as existing values for consistency.
Related Issues
This pull request has the following related issues:
References #4837 and #4955 as examples of similar improvements.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers