-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
bench: refactor to use string interpolation in mathjs #9602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Athan <[email protected]>
|
As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge. |
|
Thank you for your contribution and congratulations on your first PR! |
Resolves #{{a part of #8647}}.
Description
Refactors the JavaScript benchmarks in docs/migration-guides/mathjs/benchmark/benchmark.subtract.js to replace string concatenation with @stdlib/string/format for benchmark names.
Improves readability, consistency, and allows future linting of benchmark names.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers