Skip to content

refa: align clusterName template to use dig-based nil-safe pattern #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshiste merged 1 commit into from
Feb 20, 2026
Merged

refa: align clusterName template to use dig-based nil-safe pattern #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/steadybit-extension-istio/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: steadybit-extension-istio
description: Steadybit Istio extension Helm chart for Kubernetes.
version: 1.1.16
version: 1.1.17
appVersion: v1.0.18
home: https://www.steadybit.com/
icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png
Expand Down
4 changes: 3 additions & 1 deletion charts/steadybit-extension-istio/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,10 @@ spec:
cpu: {{ .Values.resources.limits.cpu }}
env:
{{- include "extensionlib.deployment.env" (list .) | nindent 12 }}
{{- with (.Values.kubernetes.clusterName | default (dig "clusterName" nil (.Values.global | default dict))) }}
- name: STEADYBIT_EXTENSION_CLUSTER_NAME
value: {{ if and .Values.global .Values.global.clusterName }}{{ .Values.global.clusterName | quote }}{{ else }}{{ .Values.kubernetes.clusterName }}{{ end }}
value: {{ . | quote }}
{{- end }}
{{- if .Values.discovery.attributes.excludes.virtualService }}
- name: STEADYBIT_EXTENSION_DISCOVERY_ATTRIBUTES_EXCLUDES_VIRTUAL_SERVICE
value: {{ join "," .Values.discovery.attributes.excludes.virtualService | quote }}
Expand Down
10 changes: 0 additions & 10 deletions charts/steadybit-extension-istio/tests/__snapshot__/deployment_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ manifest should match snapshot with extra env vars:
value: INFO
- name: STEADYBIT_LOG_FORMAT
value: text
- name: STEADYBIT_EXTENSION_CLUSTER_NAME
value: null
- name: FOO
value: bar
envFrom:
Expand Down Expand Up @@ -277,8 +275,6 @@ manifest should match snapshot with extra labels:
value: INFO
- name: STEADYBIT_LOG_FORMAT
value: text
- name: STEADYBIT_EXTENSION_CLUSTER_NAME
value: null
image: ghcr.io/steadybit/extension-istio:v0.0.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -453,8 +449,6 @@ manifest should match snapshot with mutual TLS using containerPaths:
value: /etc/tls/server.key
- name: STEADYBIT_EXTENSION_TLS_CLIENT_CAS
value: /etc/tls/ca.crt,/etc/tls/ca2.crt
- name: STEADYBIT_EXTENSION_CLUSTER_NAME
value: null
image: ghcr.io/steadybit/extension-istio:v0.0.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -528,8 +522,6 @@ manifest should match snapshot with podSecurityContext:
value: INFO
- name: STEADYBIT_LOG_FORMAT
value: text
- name: STEADYBIT_EXTENSION_CLUSTER_NAME
value: null
image: ghcr.io/steadybit/extension-istio:v0.0.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -604,8 +596,6 @@ manifest should match snapshot with priority class:
value: INFO
- name: STEADYBIT_LOG_FORMAT
value: text
- name: STEADYBIT_EXTENSION_CLUSTER_NAME
value: null
image: ghcr.io/steadybit/extension-istio:v0.0.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
Loading