Skip to content

Refactor experience & education tiles to use a shared RecordTile component #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 13, 2025

Conversation

steadyfall
Copy link
Owner

This PR introduces a unified layout component for both professional and educational experiences—making things cleaner, more reusable, and easier to maintain:

  • 🧱 Introduced RecordTile — a generic component for rendering consistent layouts across roles and institutions.
  • 🎓 Refactored EducationTile to use RecordTile, combining degree and major into a single display string.
  • 💼 Migrated ExperienceTile to RecordTile, simplifying layout logic and improving consistency.
  • ✍️ Renamed details to body for clearer semantic meaning in RecordTile.
  • 🧹 Cleaned up surrounding logic in the Education section and job descriptor code for better readability.

@steadyfall steadyfall self-assigned this Apr 12, 2025
@steadyfall steadyfall merged commit 3898b97 into dev Apr 13, 2025
2 checks passed
@steadyfall steadyfall deleted the dev-integrate-recordtile branch April 13, 2025 01:53
@steadyfall steadyfall added feat New feature or request ui-tweak Minor visual or layout improvements to existing UI components refactor internal code cleanup or restructuring (no visible change) labels Apr 13, 2025
@steadyfall
Copy link
Owner Author

image

Thought process behind RecordTile and why duration is always on first line irrespective of organizationBeforeRole being true or not.

@nrpatel18
Copy link

No idea, what comments are you talking about!

@steadyfall
Copy link
Owner Author

No idea, what comments are you talking about!

@nrpatel18 I believe you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request refactor internal code cleanup or restructuring (no visible change) ui-tweak Minor visual or layout improvements to existing UI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants