Fix macOS dependency search path#113
Merged
stechyo merged 1 commit intostechyo:masterfrom Dec 7, 2025
Merged
Conversation
|
I can confirm with mac that it works as intended. |
Owner
|
Thanks! |
Owner
|
Just FYI, had to make #116 to build a macOS release automatically since the changes in this PR to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Currently on macOS, the built
.dylibdoes not search its containing directory for dependencies—thus, it cannot findlibphonon.dyliband fails to load.This PR adds a linker flag to set the search path to
@loader_path, which represents the library's location, allowing the dependency to be found.The
Makefileand.gdextensionhave also been updated to include files for macOS.