Skip to content

Compat changes for 4.4.#79

Merged
stechyo merged 2 commits intomasterfrom
4.4-dev
Mar 4, 2025
Merged

Compat changes for 4.4.#79
stechyo merged 2 commits intomasterfrom
4.4-dev

Conversation

@stechyo
Copy link
Owner

@stechyo stechyo commented Nov 23, 2024

Not merging this because it breaks compat with the current stable release, but this should work with 4.4 without any forks (!!!)

Automated release compatible with 4.4-dev

@S0yKaf
Copy link

S0yKaf commented Jan 30, 2025

This seems to crash on 4.4-beta2. It works however on 4.4-dev7. is it just a matter of rebuilding the plugin with the right version of godot?

@stechyo
Copy link
Owner Author

stechyo commented Jan 30, 2025

Something may have changed in beta2 (in general, prerelease versions are anything but stable). Will check it out

@S0yKaf
Copy link

S0yKaf commented Jan 30, 2025

@stechyo I'm currently building this change on my own fork, will let you know if it works with the latest beta once its done.
https://github.com/S0yKaf/godot-steam-audio/actions/runs/13058765714/job/36436318599

@S0yKaf
Copy link

S0yKaf commented Jan 30, 2025

Ok, It still crashes on my fresh build.

@stechyo
Copy link
Owner Author

stechyo commented Jan 30, 2025

Ah I'll change the upstream on .gitmodules, we can just use godot/godot-cpp and not my fork
(... compiling ...)

@stechyo
Copy link
Owner Author

stechyo commented Jan 30, 2025

Ok I think it works now. Feel free to test the build that the action generates, I'll make another prerelease as well. Thanks for the heads-up!

@S0yKaf
Copy link

S0yKaf commented Jan 30, 2025

it works! Thank you for this awesome addon!

I would have kept using 4.4-dev7 if it wasn't for the fact it crashed when you tried duplicating lights 🤭

@jdbool
Copy link
Contributor

jdbool commented Mar 3, 2025

@stechyo Good to merge? 4.4 is released now and this branch has been working for me

@stechyo
Copy link
Owner Author

stechyo commented Mar 4, 2025

Yeah, I should have time to merge this today!

@stechyo stechyo marked this pull request as ready for review March 4, 2025 13:09
@stechyo stechyo merged commit c697f50 into master Mar 4, 2025
1 check passed
@stechyo stechyo deleted the 4.4-dev branch March 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants