Open
Conversation
0xrushi
commented
Aug 15, 2024
- Added dockerfile
- Added pyproject.toml, since poetry has better dependency resolution than pip or conda
- Added dockerfile for x86 as well as m1 mac
- Tested on notebooks till ch7, no issues
…for-trading into add-dockerfile
Owner
|
Thank you for your contribution. I would caution against attempting to install all packages for all notebooks in one environment. This makes the process unnecessarily complicated. Just because there are a lot of notebooks in one repo doesn't mean they are a 'library' to install with the standard packaging tools. The content differs from many other repos in that it relies on a broader range of libraries. Hence my recommendation to install the libraries you need as you go along. Not everybody is running all notebooks, or in the same order, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.