BUG: Fix asset writer, memoize cache, and event scheduling bugs#318
Open
pandashark wants to merge 1 commit intostefan-jansen:mainfrom
Open
BUG: Fix asset writer, memoize cache, and event scheduling bugs#318pandashark wants to merge 1 commit intostefan-jansen:mainfrom
pandashark wants to merge 1 commit intostefan-jansen:mainfrom
Conversation
Fix _weak_lru_cache double-counting misses and cache_clear() crash from subscripting integers. Materialize map() iterator to list in AssetFinder._lookup_symbol_strict to prevent exhaustion. Fix _all_tables_present to check all tables instead of returning after the first. Compare self.cal.name instead of self.cal to string in BeforeClose. Fix write_direct argument order for futures in AssetDBWriter. Closes stefan-jansen#315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 5 bugs in asset management, caching, and event scheduling utilities:
_weak_lru_cachedouble-counted misses andcache_clear()crashed trying to subscript integer counters._lookup_symbol_strictassignedmap()tocountry_codes, which was consumed byset()and empty when passed to the error constructor._all_tables_presentreturned after checking only the first table due toreturninside the loop.BeforeClosecompared a calendar object to the string"us_futures"(alwaysFalse) instead of comparingself.cal.name.write_directpassed(_futures_defaults, futures)to_generate_output_dataframewhich expects(data, defaults).Closes #315
Test plan