Fix DataPortal correctness bugs#324
Open
pandashark wants to merge 1 commit intostefan-jansen:mainfrom
Open
Conversation
- Fix _first_trading_minute set to (None, None) instead of None - Fix _get_daily_spot_value passing "minute" instead of "daily" to get_adjusted_value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #320
_first_trading_minuteset to(None, None)tuple instead ofNone_get_daily_spot_valuepassing"minute"instead of"daily"toget_adjusted_valueTest plan
flake8 src/zipline/data/data_portal.pypasses cleanfirst_trading_dayis None