Fix simulation edge cases in slippage, controls, and metrics#325
Open
pandashark wants to merge 1 commit intostefan-jansen:mainfrom
Open
Fix simulation edge cases in slippage, controls, and metrics#325pandashark wants to merge 1 commit intostefan-jansen:mainfrom
pandashark wants to merge 1 commit intostefan-jansen:mainfrom
Conversation
- Fix order.limit truthiness check in fill_price_worse_than_limit_price - Fix Positions metric calling ledger.positions property as method - Fix validate_order_params style truthiness check - Fix _can_order_asset auto_close_date truthiness check - Fix AssetDateBounds.validate start_date/end_date truthiness checks - Fix MaxOrderSize/MaxPositionSize validation truthiness checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #321
order.limittruthiness check infill_price_worse_than_limit_pricePositionsmetric callingledger.positionsproperty as methodvalidate_order_paramsstyle truthiness check_can_order_assetauto_close_date truthiness checkAssetDateBounds.validatestart_date/end_date truthiness checksMaxOrderSize/MaxPositionSizevalidation truthiness checksAll changes follow the pattern already used correctly in
Order.check_order_triggers:if self.stop is not None:.Test plan
flake8passes on modified filesPositionsmetric works in minute-emission mode