Changed init/hello. Added new classes for different Auth.

Author: stefanak-michal

phpunit.xml

@@ -13,6 +13,7 @@
             <directory suffix=".php">src/connection</directory>
             <directory suffix=".php">src/PackStream</directory>
             <directory suffix=".php">src/protocol</directory>
+            <directory suffix=".php">src/auth</directory>
             <file>src/Bolt.php</file>
         </whitelist>
     </filter>

src/Bolt.php

@@ -26,7 +26,7 @@ final class Bolt
      * @var IPacker
      */
     private $packer;
-    
+
     /**
      * @var IUnpacker
      */
@@ -53,13 +53,13 @@ final class Bolt
     private $version;
 
     /**
-     * @var string
+     * @var array|null
      */
-    private $scheme = 'basic';
+    private $routing = null;
 
     /**
      * Print debug info
-     * @var bool 
+     * @var bool
      */
     public static $debug = false;
 
@@ -89,7 +89,7 @@ public function setProtocolVersions(...$v): Bolt
      * @return Bolt
      * @throws Exception
      */
-    public function setPackStreamVersion(int $version = 1)
+    public function setPackStreamVersion(int $version = 1): Bolt
     {
         $packerClass = "\\Bolt\\PackStream\\v" . $version . "\\Packer";
         if (!class_exists($packerClass)) {
@@ -107,17 +107,7 @@ public function setPackStreamVersion(int $version = 1)
     }
 
     /**
-     * @param string $scheme
-     * @return Bolt
-     */
-    public function setScheme(string $scheme = 'basic')
-    {
-        if (in_array($scheme, ['none', 'basic', 'kerberos']))
-            $this->scheme = $scheme;
-        return $this;
-    }
-
-    /**
+     * Version is available after successful connection with init/hello message
      * @return float
      */
     public function getProtocolVersion(): float
@@ -195,19 +185,12 @@ private function packProtocolVersions(): string
 
     /**
      * Send INIT message
-     * @version <3
-     * @param string $name should conform to "Name/Version" https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent
-     * @param string $user
-     * @param string $password
-     * @param array $routing routing::Dictionary(address::String)
-     <pre>null - the server should not carry out routing
-     [] - the server should carry out routing
-     ['address' => 'ip:port'] - the server should carry out routing according to the given routing context</pre>
-     * @param array $metadata Server success response metadata
-     * @return bool
+     * @param auth\Auth $auth
+     * @return bool|array
      * @throws Exception
+     * @version <3
      */
-    public function init(string $name, string $user, string $password, array $routing = null, array &$metadata = []): bool
+    public function init(\Bolt\auth\Auth $auth)
     {
         if (!$this->connection->connect())
             return false;
@@ -218,44 +201,49 @@ public function init(string $name, string $user, string $password, array $routin
         if (self::$debug)
             echo 'INIT';
 
-        $metadata = $this->protocol->init($name, $this->scheme, $user, $password, $routing);
-        return !empty($metadata);
+        return $this->protocol->init($auth->getCredentials(), $this->routing) ?? false;
     }
 
     /**
      * Send HELLO message
-     * @internal INIT alias
-     * @version >=3
-     * @param string $name
-     * @param string $user
-     * @param string $password
-     * @param array $routing routing::Dictionary(address::String)
-    <pre>null - the server should not carry out routing
-    [] - the server should carry out routing
-    ['address' => 'ip:port'] - the server should carry out routing according to the given routing context</pre>
-     * @param array $metadata Server success response metadata
-     * @return bool
+     * @param auth\Auth $auth
+     * @return bool|array
      * @throws Exception
+     * @version >=3
+     */
+    public function hello(\Bolt\auth\Auth $auth)
+    {
+        return $this->init($auth);
+    }
+
+    /**
+     * Set routing table for HELLO message
+     * @param array|null $routing routing::Dictionary(address::String)
+     * <pre>null - the server should not carry out routing
+     * [] - the server should carry out routing
+     * ['address' => 'ip:port'] - the server should carry out routing according to the given routing context</pre>
+     * @return Bolt
      */
-    public function hello(string $name, string $user, string $password, array $routing = null, array &$metadata = []): bool
+    public function setRouting(?array $routing = null): Bolt
     {
-        return $this->init($name, $user, $password, $routing, $metadata);
+        $this->routing = $routing;
+        return $this;
     }
 
     /**
      * Send RUN message
      * @param string $statement
      * @param array $parameters
      * @param array $extra extra::Dictionary(bookmarks::List<String>, tx_timeout::Integer, tx_metadata::Dictionary, mode::String, db:String)
-    <pre>The bookmarks is a list of strings containg some kind of bookmark identification e.g [“neo4j-bookmark-transaction:1”, “neo4j-bookmark-transaction:2”]
-    The tx_timeout is an integer in that specifies a transaction timeout in ms.
-    The tx_metadata is a dictionary that can contain some metadata information, mainly used for logging.
-    The mode specifies what kind of server the RUN message is targeting. For write access use "w" and for read access use "r". Defaults to write access if no mode is sent.
-    The db specifies the database name for multi-database to select where the transaction takes place. If no db is sent or empty string it implies that it is the default database.</pre>
+     * <pre>The bookmarks is a list of strings containg some kind of bookmark identification e.g [“neo4j-bookmark-transaction:1”, “neo4j-bookmark-transaction:2”]
+     * The tx_timeout is an integer in that specifies a transaction timeout in ms.
+     * The tx_metadata is a dictionary that can contain some metadata information, mainly used for logging.
+     * The mode specifies what kind of server the RUN message is targeting. For write access use "w" and for read access use "r". Defaults to write access if no mode is sent.
+     * The db specifies the database name for multi-database to select where the transaction takes place. If no db is sent or empty string it implies that it is the default database.</pre>
      * @return array
      * @throws Exception
      */
-    public function run(string $statement, array $parameters = [], array $extra = [])
+    public function run(string $statement, array $parameters = [], array $extra = []): array
     {
         if (self::$debug)
             echo 'RUN: ' . $statement;
@@ -264,13 +252,13 @@ public function run(string $statement, array $parameters = [], array $extra = []
 
     /**
      * Send PULL_ALL message
-     * @version <4
      * @param int $n The n specifies how many records to fetch. n=-1 will fetch all records.
      * @param int $qid The qid (query identification) specifies the result of which statement the operation should be carried out. (Explicit Transaction only). qid=-1 can be used to denote the last executed statement and if no ``.
      * @return array
      * @throws Exception
+     * @version <4
      */
-    public function pullAll(int $n = -1, int $qid = -1)
+    public function pullAll(int $n = -1, int $qid = -1): array
     {
         if (self::$debug)
             echo 'PULL';
@@ -279,27 +267,27 @@ public function pullAll(int $n = -1, int $qid = -1)
 
     /**
      * Send PULL message
-     * @version >=4
-     * @internal PULL_ALL alias
      * @param int $n The n specifies how many records to fetch. n=-1 will fetch all records.
      * @param int $qid The qid (query identification) specifies the result of which statement the operation should be carried out. (Explicit Transaction only). qid=-1 can be used to denote the last executed statement and if no ``.
      * @return array Array of records. Last array element is success message.
      * @throws Exception
+     * @version >=4
+     * @internal PULL_ALL alias
      */
-    public function pull(int $n = -1, int $qid = -1)
+    public function pull(int $n = -1, int $qid = -1): array
     {
         return $this->pullAll($n, $qid);
     }
 
     /**
      * Send DISCARD_ALL message
-     * @version <4
      * @param int $n The n specifies how many records to throw away. n=-1 will throw away all records.
      * @param int $qid The qid (query identification) specifies the result of which statement the operation should be carried out. (Explicit Transaction only). qid=-1 can be used to denote the last executed statement and if no ``.
      * @return bool
      * @throws Exception
+     * @version <4
      */
-    public function discardAll(int $n = -1, int $qid = -1)
+    public function discardAll(int $n = -1, int $qid = -1): bool
     {
         if (self::$debug)
             echo 'DISCARD';
@@ -308,12 +296,12 @@ public function discardAll(int $n = -1, int $qid = -1)
 
     /**
      * Send DISCARD message
-     * @version >=4
-     * @internal DISCARD_ALL alias
      * @param int $n The n specifies how many records to throw away. n=-1 will throw away all records.
      * @param int $qid The qid (query identification) specifies the result of which statement the operation should be carried out. (Explicit Transaction only). qid=-1 can be used to denote the last executed statement and if no ``.
      * @return bool
      * @throws Exception
+     * @version >=4
+     * @internal DISCARD_ALL alias
      */
     public function discard(int $n = -1, int $qid = -1): bool
     {
@@ -322,15 +310,15 @@ public function discard(int $n = -1, int $qid = -1): bool
 
     /**
      * Send BEGIN message
-     * @version >=3
      * @param array $extra extra::Dictionary(bookmarks::List<String>, tx_timeout::Integer, tx_metadata::Dictionary, mode::String, db:String)
-    <pre>The bookmarks is a list of strings containg some kind of bookmark identification e.g [“neo4j-bookmark-transaction:1”, “neo4j-bookmark-transaction:2”]
-    The tx_timeout is an integer in that specifies a transaction timeout in ms.
-    The tx_metadata is a dictionary that can contain some metadata information, mainly used for logging.
-    The mode specifies what kind of server the RUN message is targeting. For write access use "w" and for read access use "r". Defaults to write access if no mode is sent.
-    The db specifies the database name for multi-database to select where the transaction takes place. If no db is sent or empty string it implies that it is the default database.</pre>
+     * <pre>The bookmarks is a list of strings containg some kind of bookmark identification e.g [“neo4j-bookmark-transaction:1”, “neo4j-bookmark-transaction:2”]
+     * The tx_timeout is an integer in that specifies a transaction timeout in ms.
+     * The tx_metadata is a dictionary that can contain some metadata information, mainly used for logging.
+     * The mode specifies what kind of server the RUN message is targeting. For write access use "w" and for read access use "r". Defaults to write access if no mode is sent.
+     * The db specifies the database name for multi-database to select where the transaction takes place. If no db is sent or empty string it implies that it is the default database.</pre>
      * @return bool
      * @throws Exception
+     * @version >=3
      */
     public function begin(array $extra = []): bool
     {
@@ -341,9 +329,9 @@ public function begin(array $extra = []): bool
 
     /**
      * Send COMMIT message
-     * @version >=3
      * @return bool
      * @throws Exception
+     * @version >=3
      */
     public function commit(): bool
     {
@@ -354,9 +342,9 @@ public function commit(): bool
 
     /**
      * Send ROLLBACK message
-     * @version >=3
      * @return bool
      * @throws Exception
+     * @version >=3
      */
     public function rollback(): bool
     {
@@ -379,11 +367,11 @@ public function reset(): bool
 
     /**
      * Send ROUTE message to instruct the server to return the current routing table.
-     * @version >=4.3 In previous versions there was no explicit message for this and a procedure had to be invoked using Cypher through the RUN and PULL messages.
      * @param array|null $routing
      * @param array $bookmarks
      * @param array|string|null $extra
      * @return array|null
+     * @version >=4.3 In previous versions there was no explicit message for this and a procedure had to be invoked using Cypher through the RUN and PULL messages.
      */
     public function route(?array $routing = null, array $bookmarks = [], $extra = null): ?array
     {

src/auth/Auth.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Bolt\auth;
+
+/**
+ * Class Auth
+ *
+ * @author Michal Stefanak
+ * @link https://github.com/neo4j-php/Bolt
+ * @package Bolt\auth
+ */
+abstract class Auth
+{
+    /**
+     * @var string
+     */
+    protected $userAgent;
+
+    /**
+     * @var string
+     */
+    protected $scheme;
+
+    /**
+     * @param string $userAgent
+     */
+    public function __construct(string $userAgent = 'bolt-php')
+    {
+        $this->userAgent = $userAgent;
+    }
+
+    /**
+     * Returns structured array for init/hello message
+     * @return array
+     */
+    abstract public function getCredentials(): array;
+}

src/auth/Basic.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace Bolt\auth;
+
+/**
+ * Class Basic
+ *
+ * @author Michal Stefanak
+ * @link https://github.com/neo4j-php/Bolt
+ * @package Bolt\auth
+ */
+class Basic extends Auth
+{
+    /**
+     * @inheritdoc
+     */
+    protected $scheme = 'basic';
+
+    /**
+     * @var string
+     */
+    private $username;
+
+    /**
+     * @var string
+     */
+    private $password;
+
+    /**
+     * @param string $username
+     * @param string $password
+     */
+    public function setCredentials(string $username, string $password)
+    {
+        $this->username = $username;
+        $this->password = $password;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getCredentials(): array
+    {
+        return [
+            'user_agent' => $this->userAgent,
+            'scheme' => $this->scheme,
+            'principal' => $this->username,
+            'credentials' => $this->password
+        ];
+    }
+}