Merge pull request #53 from neo4j-php/phpunit_update

Phpunit update

Author: stefanak-michal

tests/ATest.php

@@ -48,6 +48,9 @@ protected function mockConnection()
             ->method('write')
             ->with(
                 $this->callback(function ($buffer) {
+                    if ($buffer == 0x0000)
+                        return true;
+
                     $i = self::$writeIndex;
                     self::$writeIndex++;
 

tests/BoltTest.php

@@ -34,15 +34,17 @@ public function testHello(): ?Bolt
         Bolt::$debug = true;
 
         try {
-            $conn = new \Bolt\connection\StreamSocket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', $GLOBALS['NEO_PORT'] ?? 7687);
-            $this->assertInstanceOf(\Bolt\connection\StreamSocket::class, $conn);
-            $bolt = new Bolt($conn);
-            $this->assertInstanceOf(Bolt::class, $bolt);
-            $this->assertTrue($bolt->hello('Test/1.0', $GLOBALS['NEO_USER'], $GLOBALS['NEO_PASS']));
+            if (extension_loaded('sockets')) {
+                $conn = new \Bolt\connection\Socket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', $GLOBALS['NEO_PORT'] ?? 7687);
+                $this->assertInstanceOf(\Bolt\connection\Socket::class, $conn);
+                $bolt = new Bolt($conn);
+                $this->assertInstanceOf(Bolt::class, $bolt);
+                $this->assertTrue($bolt->hello('Test/1.0', $GLOBALS['NEO_USER'], $GLOBALS['NEO_PASS']));
+            }
             unset($bolt);
 
-            $conn = new \Bolt\connection\Socket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', $GLOBALS['NEO_PORT'] ?? 7687);
-            $this->assertInstanceOf(\Bolt\connection\Socket::class, $conn);
+            $conn = new \Bolt\connection\StreamSocket($GLOBALS['NEO_HOST'] ?? '127.0.0.1', $GLOBALS['NEO_PORT'] ?? 7687);
+            $this->assertInstanceOf(\Bolt\connection\StreamSocket::class, $conn);
             $bolt = new Bolt($conn);
             $this->assertInstanceOf(Bolt::class, $bolt);
             $this->assertTrue($bolt->hello('Test/1.0', $GLOBALS['NEO_USER'], $GLOBALS['NEO_PASS']));

tests/ErrorsTest.php

@@ -44,15 +44,16 @@ public function testMessageException()
         }
 
         $this->expectException(\Bolt\error\MessageException::class);
-        $bolt->hello('Test/1.0', $GLOBALS['NEO_USER'], 'wrong password');
+        $bolt->hello('Test/1.0', $GLOBALS['NEO_USER'], $GLOBALS['NEO_PASS']);
+        $bolt->run('Wrong message');
     }
 
     public function testPackException1()
     {
-        $this->expectException(\Bolt\error\PackException::class);
         $packer = new \Bolt\PackStream\v1\Packer();
         $this->assertInstanceOf(\Bolt\PackStream\v1\Packer::class, $packer);
-        $packer->pack(0x00, fopen('php://input', 'r'));
+        $this->expectException(\Bolt\error\PackException::class);
+        foreach ($packer->pack(0x00, fopen('php://input', 'r')) as $chunk) { }
     }
 
     public function testPackException2()

tests/PackStream/v1/PackerTest.php

@@ -41,7 +41,7 @@ public function test__construct(): Packer
      */
     public function testPack(string $bin, array $args, Packer $packer)
     {
-        $this->assertEquals($bin, $packer->pack(0x88, $args));
+        $this->assertEquals($bin, implode(iterator_to_array($packer->pack(0x88, $args))));
     }
 
     /**