Fix sourceData + formatData callback mismatch causing “Location not found” #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug when using
sourceDatawithLeaflet.Control.Searchwhere valid resultsare returned by the data source, but the control always reports "Location not found".
This happens due to an incorrect invocation of
formatDatawhensourceDatais used.Reproduction
L.Control.SearchwithsourceDatareturning an array of result objects(e.g.
{ title, lat, lon })A minimal repro is included in:
examples/simple-sourceData-bug.html
Fix
Ensure
formatDatais invoked consistently when usingsourceData, so that_recordsCacheis populated with the expected key → LatLng mapping.This aligns
sourceDatabehavior withurlandlayersearch modes.Files changed
src/leaflet-search.jsdist/leaflet-search.src.jsexamples/simple-sourceData-bug.html(repro + verification)Notes