Code refactor to enhance readability and maintainability#2
Open
AlbertoVargasMoreno wants to merge 2 commits intostefanofranco:mainfrom
Open
Code refactor to enhance readability and maintainability#2AlbertoVargasMoreno wants to merge 2 commits intostefanofranco:mainfrom
AlbertoVargasMoreno wants to merge 2 commits intostefanofranco:mainfrom
Conversation
- replace returns by exceptions - use catch to unify error response
- implement early return to improve readibility - define queries previous to execution, improving readibility of queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes two refactoring changes to improve the codebase:
Create the params validations function:
This change moves the validations logic into a modular function
Enhance readability of extractStats function:
These changes make the extractStats function more concise and easier to follow, enhancing the code's overall quality and maintainability.
The goal of these refactoring changes is to improve the codebase's structure, error handling, and readability, making it easier for other developers to understand and work with the code in the future.