Skip to content

add assume-404-regex flag#105

Open
vladertel wants to merge 6 commits intostefanoj3:masterfrom
vladertel:assume404substring
Open

add assume-404-regex flag#105
vladertel wants to merge 6 commits intostefanoj3:masterfrom
vladertel:assume404substring

Conversation

@vladertel
Copy link
Copy Markdown

Add ability to mark server response as 404 when it responds with 200 and "Not found" message

Add ability to mark server response as 404 when it responds with 200 and "Not found" message
@vladertel
Copy link
Copy Markdown
Author

ohhh, the PR got a little bit large since my IDE autoformatted several files. I hope you don't mind

@stefanoj3
Copy link
Copy Markdown
Owner

Hey! thanks for the PR, the makefile contains a command to format the code, this should bring the files you changed without wanting to back to normal.

I like the change but I'd appreciate if you took the time to make it more generic

rather than having a flag specific for 404 like

--assume-404-regex "404: page .* was not "

what do you think about changing it so it can be used with any status code?

example

--assume-status-code=404 --assume-regex="404: page .* was not "

@vladertel
Copy link
Copy Markdown
Author

@stefanoj3 done

@vladertel
Copy link
Copy Markdown
Author

@stefanoj3 ping. could you also make a new release and update one in homebrew?

@vladertel
Copy link
Copy Markdown
Author

@stefanoj3 ping

@stefanoj3
Copy link
Copy Markdown
Owner

Hey, sorry for the late comeback @vladertel in the next days I will review and merge if there are no issues.

Thanks for the time spent on this contribution so far.

@cli-ish
Copy link
Copy Markdown

cli-ish commented May 31, 2024

That's a feature I've wanted in this tool for a long time @vladertel thanks for this PR 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants