Conversation
Add ability to mark server response as 404 when it responds with 200 and "Not found" message
|
ohhh, the PR got a little bit large since my IDE autoformatted several files. I hope you don't mind |
|
Hey! thanks for the PR, the makefile contains a command to format the code, this should bring the files you changed without wanting to back to normal. I like the change but I'd appreciate if you took the time to make it more generic rather than having a flag specific for 404 like what do you think about changing it so it can be used with any status code? example |
fix formatting
7453114 to
27bb414
Compare
|
@stefanoj3 done |
|
@stefanoj3 ping. could you also make a new release and update one in homebrew? |
|
@stefanoj3 ping |
|
Hey, sorry for the late comeback @vladertel in the next days I will review and merge if there are no issues. Thanks for the time spent on this contribution so far. |
|
That's a feature I've wanted in this tool for a long time @vladertel thanks for this PR 👍. |
Add ability to mark server response as 404 when it responds with 200 and "Not found" message