move array type checking from enumerator to .all
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
requested changes
Jun 1, 2017
lib/es6-promise/promise/all.js
Outdated
| */ | ||
| export default function all(entries) { | ||
| if (!isArray(entries)){ | ||
| return this.reject(new TypeError('You must pass an array to all.')); |
Owner
There was a problem hiding this comment.
I don't believe the spec goes through Constructor.reject here.
Owner
There was a problem hiding this comment.
Other then ^ I am good with this direction.
Owner
Tests on master are now green :) |
|
According to MDN the input is iterable, so Array is not enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.