Merged
Conversation
- split tests per function for readability - implement printAwareHandler as own file - migrate README from markdown to AsciiDoc and add example - make print functions use the same out stream as the logger - add ErrorLn, FatalLn, InfoLn, and WarnLn functions for newline logging - split tests per file and increase coverage >80% - cover non-f and *Ln variants + fatal forks - remove logger_test.go file - add tests for package-level Fatal functions with forking - Add error checks for all w.Close() calls in test files - Assign Close() return to err and verify with assert.NoError - Add tests for config.go (Format.String, ParseFormat) - Add tests for PrintAwareHandler (WithAttrs, WithGroup) - Add tests for logger.go (Field, ParseText) - Add package-level Fatal function tests with fork pattern - Improve coverage to 94.5% for main package, 78.4% total
steffakasid
force-pushed
the
refactoring
branch
from
fcb7b05 to
18b79fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.