Replace pytweening with local easing functions#158
Merged
stefmolin merged 9 commits intostefmolin:mainfrom Jun 8, 2024
Merged
Conversation
stefmolin
reviewed
May 23, 2024
Owner
stefmolin
left a comment
There was a problem hiding this comment.
Thanks for the PR, @flpm!
Let's also include individual tests for each of the new functions. I know they are tested indirectly as part of the DataMorpher, but it would be helpful to have pure tests of their functionality for future changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 98.38% 98.42% +0.03%
==========================================
Files 43 43
Lines 1737 1775 +38
Branches 345 358 +13
==========================================
+ Hits 1709 1747 +38
Misses 25 25
Partials 3 3
|
stefmolin
reviewed
Jun 1, 2024
Co-authored-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
stefmolin
reviewed
Jun 8, 2024
449636f to
c79215d
Compare
stefmolin
approved these changes
Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157
What was done:
plotting/animationmorpher.pywith the new functionspyproject.toml'python'withsys.executablein CLI test