Add option to preserve the median when morphing #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 98.80% 98.82% +0.01%
==========================================
Files 84 84
Lines 2099 2128 +29
Branches 123 128 +5
==========================================
+ Hits 2074 2103 +29
Misses 24 24
Partials 1 1
🚀 New features to boost your workflow:
|
stefmolin
requested changes
Jul 13, 2024
Owner
stefmolin
left a comment
stefmolin
left a comment
There was a problem hiding this comment.
I'm running this on multiple different shapes to make sure this doesn't constrict things, but I do have some comments for now.
The statistics here are way too close together it is hard to read. Can we space them out more vertically?
stefmolin
requested changes
Feb 18, 2025
src/data_morph/plotting/static.py
Outdated
| res = get_summary_statistics(data) | ||
|
|
||
| labels = ('X Mean', 'Y Mean', 'X SD', 'Y SD', 'Corr.') | ||
| labels = ('X Mean', 'Y Mean', 'X Med.', 'Y Med.', 'X SD', 'Y SD', 'Corr.') |
Owner
There was a problem hiding this comment.
Maybe doing this in groups would fix the spacing issue:
X Mean
X Med.
X SD.
Y Mean
Y Med.
Y SD.
Corr.
stefmolin
changed the title
stefmolin
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Describe your changes
Add option to preserve the median when morphing
Checklist