Merged
Conversation
There was a problem hiding this comment.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 98.42% 98.45% +0.02%
==========================================
Files 43 43
Lines 1775 1807 +32
Branches 358 357 -1
==========================================
+ Hits 1747 1779 +32
Misses 25 25
Partials 3 3
|
stefmolin
requested changes
Sep 27, 2024
Owner
stefmolin
left a comment
There was a problem hiding this comment.
Thank you, @kevin1kevin1k! I left a few small comments for you to address, but this looks fantastic 😍
Contributor
Author
|
Thanks for the suggestions! I have applied them. |
stefmolin
approved these changes
Oct 1, 2024
Owner
stefmolin
left a comment
There was a problem hiding this comment.
Thanks for making the changes. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
Describe your changes
Add the Club target shape
Checklist
Datasets that work best with Club shape: