Conversation
There was a problem hiding this comment.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 98.42% 98.47% +0.04%
==========================================
Files 43 43
Lines 1775 1832 +57
Branches 358 357 -1
==========================================
+ Hits 1747 1804 +57
Misses 25 25
Partials 3 3
|
stefmolin
left a comment
There was a problem hiding this comment.
Thanks for the PR, @kunxianhuang! I pushed some changes to clean things up after working with the code from the other PR. Can you please add a test class for the spade?
You can start from what was in #195:
data-morph/tests/shapes/test_points.py
Lines 147 to 156 in 4d3ed9d
stefmolin
left a comment
There was a problem hiding this comment.
Thanks for your help with this one @kunxianhuang!
Fixes #163
Describe your changes
Add spade shape
Checklist