Skip to content

Copy duplicate frames rather than rerendering so progress tracker starts sooner #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefmolin merged 1 commit into from
Feb 16, 2025
Merged

Copy duplicate frames rather than rerendering so progress tracker starts sooner #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 36 additions & 22 deletions src/data_morph/morpher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import shutil
from contextlib import nullcontext
from functools import partial
from numbers import Number
Expand Down Expand Up @@ -223,31 +224,44 @@ def _record_frames(
int
The next frame number available for recording.
"""
if self.write_images or self.write_data:
if (self.write_images or self.write_data) and count > 0:
is_start = frame_number == 0
for _ in range(count):
if self.write_images:
plot(
data,
save_to=(
img_file = (
self.output_dir / f'{base_file_name}-image-{frame_number:03d}.png'
)
data_file = (
self.output_dir / f'{base_file_name}-data-{frame_number:03d}.csv'
)
if self.write_images:
plot(
data,
save_to=img_file,
decimals=self.decimals,
x_bounds=bounds.x_bounds,
y_bounds=bounds.y_bounds,
dpi=150,
)
if (
self.write_data and not is_start
): # don't write data for the initial frame (input data)
data.to_csv(data_file, index=False)
frame_number += 1
if (duplicate_count := count - 1) > 0:
for _ in range(duplicate_count):
if data_file.exists():
shutil.copy(
data_file,
self.output_dir
/ f'{base_file_name}-image-{frame_number:03d}.png'
),
decimals=self.decimals,
x_bounds=bounds.x_bounds,
y_bounds=bounds.y_bounds,
dpi=150,
)
if (
self.write_data and not is_start
): # don't write data for the initial frame (input data)
data.to_csv(
self.output_dir
/ f'{base_file_name}-data-{frame_number:03d}.csv',
index=False,
)
/ f'{base_file_name}-data-{frame_number:03d}.csv',
)
if img_file.exists():
shutil.copy(
img_file,
self.output_dir
/ f'{base_file_name}-image-{frame_number:03d}.png',
)
frame_number += 1

frame_number += 1
return frame_number

def _is_close_enough(self, df1: pd.DataFrame, df2: pd.DataFrame) -> bool:
Expand Down