Skip to content

Conversation

@stefmolin
Copy link
Owner

  • Rework calculations for Circle, Bullseye, and Rings shapes
  • Separate the Circle, Bullseye, and Rings shapes into separate modules
  • Separate calculation for radii for Bullseye and Rings
  • Change Rings shape to be only three circles
  • Expand test cases for Circle, Bullseye, and Rings shapes

@github-actions github-actions bot added testing Relating to the testing suite shapes Work relating to shapes module bounds Work relating to the bounds module. labels Feb 22, 2025
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (fc93eaa) to head (275c856).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   98.63%   98.80%   +0.16%     
==========================================
  Files          81       84       +3     
  Lines        2058     2097      +39     
  Branches      121      121              
==========================================
+ Hits         2030     2072      +42     
+ Misses         26       24       -2     
+ Partials        2        1       -1     
Files with missing lines Coverage Δ
src/data_morph/bounds/bounding_box.py 100.00% <100.00%> (ø)
src/data_morph/shapes/circles/__init__.py 100.00% <100.00%> (ø)
src/data_morph/shapes/circles/bullseye.py 100.00% <100.00%> (ø)
src/data_morph/shapes/circles/circle.py 100.00% <100.00%> (ø)
src/data_morph/shapes/circles/rings.py 100.00% <100.00%> (ø)
tests/shapes/circles/bases.py 100.00% <100.00%> (ø)
tests/shapes/circles/test_bullseye.py 100.00% <100.00%> (ø)
tests/shapes/circles/test_circle.py 100.00% <100.00%> (ø)
tests/shapes/circles/test_rings.py 100.00% <100.00%> (ø)

@stefmolin stefmolin merged commit 82c8ba6 into main Feb 22, 2025
23 checks passed
@stefmolin stefmolin deleted the circle-shape-updates branch February 22, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bounds Work relating to the bounds module. shapes Work relating to shapes module testing Relating to the testing suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants