Skip to content

Fix Android build#690

Merged
CassioMG merged 1 commit intomainfrom
cg-fix-app-install
Jan 23, 2026
Merged

Fix Android build#690
CassioMG merged 1 commit intomainfrom
cg-fix-app-install

Conversation

@CassioMG
Copy link
Contributor

What

Android build started failing after the changes from the Pins all dependencies PR due to react-native-screens using a deprecated React Native API (ShadowNode::Shared). Upgrading the react-native-screens fixed the issue.

Why

So we can build and install the Android app again.

Screenshot 2026-01-22 at 16 55 31

Known limitations

N/A

Checklist

PR structure

  • This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not).
  • This PR has reasonably narrow scope (break it down into smaller PRs if not).
  • This PR includes relevant before and after screenshots/videos highlighting these changes.
  • I took the time to review my own PR.

Testing

  • These changes have been tested and confirmed to work as intended on Android.
  • These changes have been tested and confirmed to work as intended on iOS.
  • These changes have been tested and confirmed to work as intended on small iOS screens.
  • These changes have been tested and confirmed to work as intended on small Android screens.
  • I have tried to break these changes while extensively testing them.
  • This PR adds tests for the new functionality or fixes.

Release

  • This is not a breaking change.
  • This PR updates existing JSDocs when applicable.
  • This PR adds JSDocs to new functionalities.
  • I've checked with the product team if we should add metrics to these changes.
  • I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes.

Copilot AI review requested due to automatic review settings January 23, 2026 00:56
@CassioMG CassioMG requested review from aristidesstaffieri and removed request for Copilot January 23, 2026 00:56
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​react-native-screens@​4.11.1 ⏵ 4.20.099100100100100

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Android build failures by upgrading react-native-screens from version 4.11.1 to 4.20.0. The build was failing after PR #671 pinned all dependencies, as the older version used a deprecated React Native API (ShadowNode::Shared).

Changes:

  • Upgraded react-native-screens from 4.11.1 to 4.20.0
  • Removed obsolete react-native-is-edge-to-edge@npm:^1.1.7 dependency reference in yarn.lock
  • Updated iOS Podfile.lock to reflect the new version

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updated react-native-screens dependency to 4.20.0
yarn.lock Updated package resolution, removed obsolete dependency reference, and updated checksums
ios/Podfile.lock Updated RNScreens pod version references and checksum for iOS compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CassioMG CassioMG merged commit 76af466 into main Jan 23, 2026
19 checks passed
@CassioMG CassioMG deleted the cg-fix-app-install branch January 23, 2026 02:07
@github-actions github-actions bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants