Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Android build failures by upgrading react-native-screens from version 4.11.1 to 4.20.0. The build was failing after PR #671 pinned all dependencies, as the older version used a deprecated React Native API (ShadowNode::Shared).
Changes:
- Upgraded
react-native-screensfrom 4.11.1 to 4.20.0 - Removed obsolete
react-native-is-edge-to-edge@npm:^1.1.7dependency reference in yarn.lock - Updated iOS Podfile.lock to reflect the new version
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated react-native-screens dependency to 4.20.0 |
| yarn.lock | Updated package resolution, removed obsolete dependency reference, and updated checksums |
| ios/Podfile.lock | Updated RNScreens pod version references and checksum for iOS compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Android build started failing after the changes from the Pins all dependencies PR due to
react-native-screensusing a deprecated React Native API (ShadowNode::Shared). Upgrading thereact-native-screensfixed the issue.Why
So we can build and install the Android app again.
Known limitations
N/A
Checklist
PR structure
Testing
Release