Conversation
* adds the scrollable prop to history detail bottom sheet * refactor history detail bottom sheet to use the render footer pattern, allowing for dynamic height when scrollable * Memoize renderFooterComponent to prevent unnecessary re-renders (#688) * Initial plan * Memoize renderFooterComponent with useCallback Co-authored-by: aristidesstaffieri <6886006+aristidesstaffieri@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aristidesstaffieri <6886006+aristidesstaffieri@users.noreply.github.com> * tweaks credit and debit row key, adds a max height based on viewport to detail sheet --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: aristidesstaffieri <6886006+aristidesstaffieri@users.noreply.github.com>
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This release bumps the app to version 1.11.25 and refines transaction history rendering, especially around asset balance changes, transaction details layout, and bottom sheet behavior, with corresponding test updates. It also propagates the new version across iOS and Android build metadata.
Changes:
processAssetBalanceChangesnow filters Horizonasset_balance_changesto only include entries where the user is sender or receiver, and tests are updated to assert the new behavior.- Transaction details bottom sheet content/layout is adjusted to better handle multi-asset diffs and safe-area-aware footers, and
BottomSheetgains amaxDynamicContentSizeprop for improved dynamic sizing. - Application version updated to 1.11.25 across
package.json, iOS Info plists, Xcode projectMARKETING_VERSION, and AndroidversionName.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/helpers/assetBalanceChanges.ts |
Adds filtering so only user-involved asset balance changes are processed into summaries. |
__tests__/helpers/assetBalanceChanges.test.ts |
Updates and extends tests to cover the new user-involvement filtering semantics and keep other behaviors verified. |
src/components/screens/HistoryScreen/TransactionDetailsBottomSheetCustomContent.tsx |
Refactors transaction details UI, improves asset diff keys, and introduces a safe-area-aware TransactionDetailsFooter that handles the external explorer link. |
src/components/screens/HistoryScreen/HistoryList.tsx |
Wires the new footer into the transaction details bottom sheet and constrains dynamic content size based on window height. |
src/components/BottomSheet.tsx |
Exposes a maxDynamicContentSize prop and forwards it to BottomSheetModal to bound dynamic sizing; supports external footers with layout measurement. |
package.json |
Bumps app version string to 1.11.25. |
ios/freighter-mobile/Info.plist |
Updates iOS bundle short version to 1.11.25. |
ios/freighter-mobile/Info-Dev.plist |
Updates dev Info.plist short version to 1.11.25. |
ios/freighter-mobile.xcodeproj/project.pbxproj |
Updates Xcode MARKETING_VERSION entries to 1.11.25. |
android/app/build.gradle |
Updates Android versionName to 1.11.25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.11.25 – What’s new
This release focuses on transaction/history UX improvements, token icon reliability, and mobile build + performance updates, plus dependency upgrades.
Transaction history improvements
Token icons & visuals
Discovery / dApp UX tweaks
Build, performance & maintenance