[CI] Migrate iOS workflow to GitHub App Token#725
Conversation
…o Workload Identity Federatio
There was a problem hiding this comment.
Pull request overview
This pull request migrates the iOS CI workflow from SSH deploy key authentication to GitHub App token authentication for accessing the private Fastlane Match certificates repository. This improves security by using short-lived tokens (1 hour) instead of long-lived SSH keys and follows the principle of least privilege.
Changes:
- Replaced SSH deploy key authentication with GitHub App token via
actions/create-github-app-token@v2 - Updated Fastlane Match configuration to use
git_basic_authorizationinstead ofgit_private_key - Added explicit
permissions: contents: readfor security hardening
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ios.yml |
Added GitHub App token generation step, removed SSH key references, added explicit permissions |
fastlane/Fastfile |
Changed authentication from SSH private key to GitHub App token with basic authorization |
fastlane/Matchfile |
Removed git_url configuration (now set dynamically in Fastfile) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # .github/workflows/ios.yml
|
I will keep this closed while we wait for ops |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
from SSH deploy keyauthenticationto GitHub App tokenfor accessing the private Match certificates repository
Changes
FASTLANE_GIT_DEPLOY_KEY(SSH deploy key) with GitHub App token viaactions/create-github-app-token@v2MATCH_GITHUB_APP_ID(repository variable) andMATCH_GITHUB_APP_PRIVATE_KEY(secret) for GitHub App authenticationgit_basic_authorizationin Match instead ofgit_private_keypermissions: contents: readfor security hardeninggit_urlfromMatchfile(set dynamically in Fastfile)git_basic_authorizationwith GitHub Apptoken
Required Configuration
MATCH_GITHUB_APP_IDMATCH_GITHUB_APP_PRIVATE_KEYWhy
scoped to specific repositories
token scoped only to
freighter-mobile-fastlanerepositoryKnown limitations
Ops team to configure the GitHub App - DONE ✅
Checklist
PR structure
Testing
Release