[QA 1.11] Adjust hash key refresh and infinite loading#732
Closed
leofelix077 wants to merge 7 commits intomainfrom
Closed
[QA 1.11] Adjust hash key refresh and infinite loading#732leofelix077 wants to merge 7 commits intomainfrom
leofelix077 wants to merge 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses authentication flow issues related to hash key refresh and infinite loading states. The changes focus on improving the initialization sequence in RootNavigator to prevent race conditions, adjusting the logout flow to avoid showing authenticated screens during data wipe, and adding better error handling for biometric authentication failures.
Changes:
- Refactored RootNavigator initialization to wait for auth status to be fetched before rendering UI, preventing flashing of wrong screens
- Modified logout flow to immediately set NOT_AUTHENTICATED state before async cleanup operations
- Added error toast notifications for biometric authentication and unlock failures
- Changed shouldRefreshHashKey parameter from false to true in signIn flow (potential issue identified)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/navigators/RootNavigator.tsx | Adds isAuthStatusReady state to prevent rendering until auth status is loaded from storage; uses refs to capture biometric values |
| src/hooks/useAppOpenBiometricsLogin.ts | Adds AUTH_STATUS.LOCKED to biometric login trigger condition and error toast handling |
| src/components/screens/LockScreen.tsx | Adds error toast for non-password-related unlock errors |
| src/ducks/auth.ts | Changes shouldRefreshHashKey to true (creates redundancy issue); improves logout flow by setting state before async cleanup |
| src/i18n/locales/en/translations.json | Adds error messages for wallet unlock failures |
| src/i18n/locales/pt/translations.json | Adds Portuguese translations for error messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
PR structure
Testing
Release