Open
Conversation
Ryang-21
requested review from
Shaptic and
Copilot
and removed request for
Copilot
quietbits
approved these changes
Mar 2, 2026
quietbits
left a comment
quietbits
left a comment
There was a problem hiding this comment.
I'm not super familiar with this repo, but the update looks OK to me.
Ryang-21
commented
Mar 3, 2026
Comment on lines
+338
to
+339
| [-1n, 64, 32, [0xffffffffn, 0xffffffffn]], | ||
| [0xfffffffffffffffen, 64, 32, [0xfffffffen, 0xffffffffn]], |
Contributor
Author
There was a problem hiding this comment.
sliceBigInt was changed to encode the bigint slices as uint. Is this a breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This fixes silent truncation that occurred when encoding
LargeIntby checking that the bytes to be encoded are of the appropriate size. This is necessary as theBigInt.asUintNandBigInt.asintNmethods truncate the higher bits when they exceed the providedsizeparam given to the function.Validation
Tests were added to check functionality at the max and min bounds of the sized integer. Values that are beyond the bounds were tested to throw.