-
Notifications
You must be signed in to change notification settings - Fork 226
Move history archive to /opt/stellar for persistence #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR relocates the history archive storage from /tmp/stellar-core/history/vs to /opt/stellar/history-archive/data to ensure persistence across container restarts in persistent mode. The /tmp directory is not included in the standard /opt/stellar volume mount, causing history archive data loss on container restarts.
Key Changes:
- Updated history archive path from
/tmp/stellar-core/history/vsto/opt/stellar/history-archive/datain both stellar-core configuration and supervisor configuration - Changes only affect the local network configuration (testnet, pubnet, and futurenet use remote history archives)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| local/supervisor/etc/supervisord.conf.d/history-archive.conf | Updated the working directory for the history archive HTTP server to point to the new persistent location |
| local/core/etc/stellar-core.cfg | Updated all HISTORY.vs commands (get, put, mkdir) to use the new persistent path under /opt/stellar |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mootz12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - why only history archives for local networks?
The history archives fro networks are big enough to be non-trivial for a non-local, even testnet when its nearing its reset period. The history archival would be partial only based on what the quickstart image had seen in ledgers, so it wouldn't have all of history. Someone testing with quickstart with a non-local network could just point to a history archive sitting on s3 and they'll get a better experience. Maybe there's some utility for it, but it hasn't shown up yet. |
What
Relocate history archive storage from
/tmp/stellar-core/history/vsto/opt/stellar/history-archive/data. Update stellar-core config and supervisor config to use the new path.Why
History archive data is lost across container restarts because
/tmpis not included in the standard/opt/stellarvolume mount for persistent mode.Close #871