This repository was archived by the owner on Jan 8, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update Dockerfile #173
Open
danielcdz
wants to merge
4
commits into
stellar:update-P21
Choose a base branch
from
danielcdz:update-P21
base: update-P21
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Dockerfile #173
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,24 @@ | ||
| # Based on Preview 7 | ||
| # https://soroban.stellar.org/docs/reference/releases | ||
|
|
||
| FROM ubuntu:22.04 | ||
|
|
||
| RUN apt update && apt install -y curl | ||
| ENV PATH="/root/.cargo/bin:${PATH}" | ||
| ENV PATH="$PATH:/workspace/target/bin" | ||
| ENV IS_USING_DOCKER=true | ||
| ENV SOROBAN_CLI_REVISION="c7fb7e08ba8efa9828d9df863d991558f269e35b" | ||
| ENV GIT_REVISION=$SOROBAN_CLI_REVISION | ||
|
|
||
| RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs > rust_install.sh | ||
| RUN sh rust_install.sh -y | ||
| RUN echo $PATH | ||
| ENV PATH="$PATH:/root/.cargo/bin" | ||
| RUN rustup target add wasm32-unknown-unknown | ||
| RUN apt update && \ | ||
| apt install -y curl build-essential && \ | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && \ | ||
| rustup target add wasm32-unknown-unknown | ||
|
|
||
| RUN apt install -y build-essential | ||
| # WORKDIR / | ||
| RUN mkdir /workspace | ||
| WORKDIR /workspace | ||
| ENV IS_USING_DOCKER=true | ||
|
|
||
| COPY .cargo /root/.cargo | ||
|
|
||
| RUN cargo install_soroban | ||
|
|
||
| WORKDIR /workspace/target/bin | ||
|
|
||
| CMD ["./soroban", "--version"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though it was part of the dependencies needed for an update, if not I can rollback that change and update the Dockerfile accorndingly 🫡
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example shouldn't have any special logic for installing the CLI and definitely shouldn't be installing an arbitrary commit from another repo.
Fwiw that commit sha is not currently present on any branch or tag of the stellar/stellar-cli or AhaLabs/soroban-tools repos, meaning that the commit could be from any fork and may contain history and code from anywhere.
Imo we should direct folks to the getting started help where several options for installing the CLI exist.
Why: For some folks installing the CLI from source is impossible or at least a high barrier due to resource limitations, or dependencies they don't have installed. The main install instructions for the CLI include ways to install binaries without from source, and folks should use them where possible.
So the improvement should be imo to remove this bespoke
install_stellarcommand and ask users to install the stellar-cli themselves.