Skip to content

Handle contract build info when multiple attestations are available. #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fnando merged 2 commits into from
Jan 16, 2026
Merged

Handle contract build info when multiple attestations are available. #2359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e40756
Handle contract build info when multiple attestations are available.
fnando Jan 16, 2026
f8ac6f0
Be more consise with then_some.
fnando Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions cmd/soroban-cli/src/commands/contract/info/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,25 @@ impl Cmd {
print.infoln(format!("Collecting GitHub attestation from {url}"));
let resp = http::client().get(url).send().await?;
let resp: gh_attest_resp::Root = resp.json().await?;
let Some(attestation) = resp.attestations.first() else {
return Err(Error::AttestationNotFound);
};
let Ok(payload) = base64::engine::general_purpose::STANDARD
.decode(&attestation.bundle.dsse_envelope.payload)
else {
return Err(Error::AttestationInvalid);
};
let payload: gh_payload::Root = serde_json::from_slice(&payload)?;

// Find the SLSA provenance attestation (not the Release attestation)
// GitHub may attach multiple attestations, and we need the one with predicate_type
// matching "https://slsa.dev/provenance/v1"
let payload = resp
.attestations
.iter()
.find_map(|attestation| {
let payload = base64::engine::general_purpose::STANDARD
.decode(&attestation.bundle.dsse_envelope.payload)
.ok()?;
let payload: gh_payload::Root = serde_json::from_slice(&payload).ok()?;

(payload.predicate_type == "https://slsa.dev/provenance/v1").then_some(payload)
})
.ok_or(Error::AttestationNotFound)?;

print.checkln("Attestation found linked to GitHub Actions Workflow Run:");

let workflow_repo = payload
.predicate
.build_definition
Expand All @@ -117,7 +126,7 @@ impl Cmd {
.build_definition
.resolved_dependencies
.first()
.unwrap()
.ok_or(Error::AttestationInvalid)?
.digest
.git_commit;
let runner_environment = payload
Expand Down