WIP: Tsan on rust #4850
Closed
WIP: Tsan on rust #4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
will re-open a variant of this with more stuff elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch for properly enabling rust-with-tsan inside the core build (currently extending #4817 to facilitate running those parallel testcases, but it doesn't depend on any of that work).
Unfortunately propagating the tsan flags through our "separate crates build" is .. extremely hard to get working right.
So I took a different tack here and just added a mode --
--enable-unified-rust-unsafe-for-production-- to the core build system that buildslibrust_stellar_core.aas a single cargo invocation "the normal way you'd expect", and the way we used to, building the sub-soroban crates as direct dependencies resolved by cargo and linked directly into that crate, not driven by automake. This all works! And nice to know: it also shows no tsan errors in our code currently.So this is .. very convenient for fiddling with cargo-supported build tricks like "turning on tsan" (and it's also helpful to have as a mode we can switch in the IDE while editing/debugging) but it does risk drift in transitive dependencies -- it undermines the whole reason we have the "separate crates build" in the first place.