Fix devcontainer to work with noble #5115
Merged
+54
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
previously approved these changes
Jan 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the devcontainer configuration to work with Ubuntu Noble (24.04), addressing a critical issue where the devcontainer is currently non-functional. The changes update package sources paths, improve user creation logic, consolidate package installations, and modernize the VSCode configuration structure.
Changes:
- Updated devcontainer from Ubuntu 20.04 to Ubuntu 24.04 (Noble)
- Modernized VSCode devcontainer.json structure using the
customizationsfield - Added development tool extensions for C++, Rust, and debugging support
- Improved Dockerfile user/group creation logic to handle existing UIDs/GIDs
- Updated apt sources path for Noble and consolidated package installations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .devcontainer/devcontainer.json | Updated to Ubuntu 24.04 reference, modernized structure with customizations field, added VSCode extensions for development |
| .devcontainer/Dockerfile | Updated apt sources path for Noble, improved user creation logic, consolidated package installation with gcc-14 and clang-20 |
graydon
force-pushed
the
fix-devcontainer
branch
3 times, most recently
from
9aefbe3 to
8e638b1
Compare
graydon
force-pushed
the
fix-devcontainer
branch
from
8e638b1 to
873c59e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there was a lot more feedback than I anticipated on #5111 I've split out the most important step of it for now: fixing the devcontainer to actually work with noble / support our current build. The devcontainer literally doesn't work currently, so this is fairly high value to land asap.