Fix close time bug for slow nodes as genesis #5116
Merged
+82
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested review from
bboston7 and
Copilot
and removed request for
Copilot
marta-lokhova
force-pushed
the
closeTimeFix
branch
from
244d70a to
4caa406
Compare
There was a problem hiding this comment.
Pull request overview
Adds/adjusts simulation-based regression coverage around consensus progress when nodes are slow/out-of-sync near genesis, with an additional overlay test configuration tweak.
Changes:
- Add a new herder simulation test ensuring a late-joining node can still reach consensus after other nodes become “syncing”.
- Adjust overlay simulation config in a topology recovery test by lowering
MAX_SLOTS_TO_REMEMBER.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/overlay/test/OverlayTests.cpp | Sets MAX_SLOTS_TO_REMEMBER = 2 in the disconnected-topology recovery simulation config. |
| src/herder/test/HerderTests.cpp | Adds a new simulation test for late joiners reaching consensus under tight close-time drift constraints. |
marta-lokhova
force-pushed
the
closeTimeFix
branch
2 times, most recently
from
219e56b to
ee8ee42
Compare
marta-lokhova
force-pushed
the
closeTimeFix
branch
from
ee8ee42 to
abb03f2
Compare
bboston7
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.