Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds komet configuration and a komet-sink-carbon contract for use with the K fuzzer and prover.
The komet experiments have led to improvements in our cargo test setup, and in contract error handling and reporting. Our previous error handling could lead to SAC errors being masked. We still want to return custom errors for common user mistakes, and now improve clarity by publishing events for the SAC errors that we handle.
The property verification for
sink_carbonis not yet complete. We aim to verify that the operation does a particular atomic swap—fromfundertorecipientand fromCARBONtoCarbonSINK—without any side-effects, and that the recipient's CarbonSINK balance is always de-authorized at the end. To be able to do this in komet, we need a WASM implementation of the SAC, which is not yet available. This prerequisite is tracked in runtimeverification/komet#90.