Skip to content

Fix: Render notices after page actions if present #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonTheAdams merged 4 commits into from
Jul 10, 2025
Merged

Fix: Render notices after page actions if present #14

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6eb91f
fix: render notices after page actions when available
JoshuaHungDinh Jul 10, 2025
9a6973c
fix: Update GitHub Actions cache action to v34 to fix deprecation error
JoshuaHungDinh Jul 10, 2025
6a15f90
doc: add descriptive comment
JoshuaHungDinh Jul 10, 2025
900a959
doc: improve comment description
JoshuaHungDinh Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
id: get-composer-cache-dir
run: |
echo "::set-output name=dir::$(composer config cache-files-dir)"
- uses: actions/cache@v2
- uses: actions/cache@v4
id: composer-cache
with:
path: ${{ steps.get-composer-cache-dir.outputs.dir }}
Expand Down
5 changes: 5 additions & 0 deletions src/resources/admin-notices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@
const location = $notice.data(locationAttribute);

if (location === 'below_header') {
const $pageTitleAction = $('a.page-title-action');
if ($pageTitleAction.length) {
$notice.insertAfter($pageTitleAction);
} else {
$notice.insertAfter('h1');
}
} else if (location === 'above_header') {
$notice.insertBefore('h1');
} else if (location === 'inline') {
Expand Down
Loading