Skip to content

Conversation

@ravinderk
Copy link

@ravinderk ravinderk commented Feb 3, 2026

Description

This pull request implement Playwright setup for E2E testing.

Noticeable changes

  • PHP test groups in tests/php
  • E2E test groups in tests/e2e

Test

To run tests follow steps mentioned in tests\e2e\README.md

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🎉 Zip build complete

Build timestamp

@ravinderk ravinderk marked this pull request as ready for review February 3, 2026 10:15
@ravinderk ravinderk self-assigned this Feb 3, 2026
Secret key helps to install composer dependecies.
@mark-c-woodard
Copy link

This looks great!

2 things so far
first can you point the to the fse-experiment branch please. That's where our current working area is.

Second, where would testing library tests fit into this if we decide we want to use them for component level testing? Do you think those would go in the packages since the goal is get them seperated out?

remove wp-env package.json because it is replaced with slic
@ravinderk ravinderk changed the base branch from master to feat/fse-experiment February 10, 2026 06:00
@ravinderk
Copy link
Author

ravinderk commented Feb 10, 2026

@mark-c-woodard

can you point the to the fse-experiment branch please. That's where our current working area is.

I updated the pull request with working branch.

Second, where would testing library tests fit into this if we decide we want to use them for component level testing? Do you think those would go in the packages since the goal is get them seperated out?

You are correct. We decide to use Testing Library for component-level testing, those tests would be best placed within the packages. This approach aligns with our goal of keeping tests separated. In the plugin, we will focus on integration testing, while in the packages, we will test the output (HTML).

The incorrect plugin name is causing the tests to fail. We can temporarily update the plugin name and revert it once development is complete. There is no need for concern, as the tests will fail again if the plugin is renamed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants