Bugfix: Rowlayout margin issues #852
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 margin-related issues with the Row Layout block that this PR addresses:
Rowlayout uses its own version of
getSpacingOptionOutput()that does not correctly return an empty string for all false-y values, including''andnull. This results in the margin reset state to not work. Now the block uses the shared version of this function from@kadence/helpersthat correctly handles these false-y values.There are editor-only styles that zero out the top and bottom margins of the Rowlayout block. This can conflict with theme styles, especially due to their high specificity, resulting in inconsistent visual spacing between the editor preview and the front end display. Since there isn't an apparent need for these styles, they have been removed so that default theme margins can render correctly in both the preview and front end.
Checklist
Block specific checklist (where relevant)