KAD-5303 Reload design library previews if no data exists #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🎉 Zip build complete |
mark-c-woodard
approved these changes
Jan 13, 2026
mark-c-woodard
changed the base branch from
master
to
release/next-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue with design library previews not loading is related to how much of data we're passing in wp_localize_script. This automatically reloads the data if non is present to fix the issue.
The original plan was to load the icons via a rest request to reduce the size of data we're passing. That was working in my testing last month, but it seems something has changed and that no longer works. The larger fix here is to load the design library data via a rest request, maybe even store it in the cache using the browser cache api. This should work for now though