Introduce truncate method #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkweb
approved these changes
Jan 10, 2025
Member
borkweb
left a comment
borkweb
left a comment
There was a problem hiding this comment.
That's a really smart change!
defunctl
reviewed
Jan 10, 2025
| * | ||
| * @return int|false The number of removed rows, or `false` to indicate a failure. | ||
| */ | ||
| public function truncate() { |
Contributor
There was a problem hiding this comment.
If this is going to be a public method, shouldn't this be added to the Schema_Interface and do a major version release as this would be a breaking change?
Member
Author
There was a problem hiding this comment.
@defunctl i am not against that - i just didnt consider it necessary. Happy to follow what you think is best in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
truncatemethod that does what theempty_tablewas doing.The reason is that
TRUCNATEcauses implicit commits - make it not suitable to be used during testing in most cases.Now the method
empty_tablewill simply delete everything from that table with the only difference not resseting the AUTO_INCREMENT if it exists. That should be ok.Moreover it prevents multile "check" queries before deciding if we can or cant update the tables during the current request.